SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

fixing BertForQuestionAnswering loss computation

Browse Source
This commit is contained in:
thomwolf
2018-11-05 13:21:11 +01:00
parent bb5ce67a14
commit a725db4f6c
1 changed files with 21 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
modeling.py
View File

@@ -384,16 +384,16 @@ class BertForSequenceClassification(nn.Module):
self.dropout = nn.Dropout(config.hidden_dropout_prob)
self.classifier = nn.Linear(config.hidden_size, num_labels)
def init_weights(m):
if isinstance(m, (nn.Linear, nn.Embedding)):
def init_weights(module):
if isinstance(module, (nn.Linear, nn.Embedding)):
# Slightly different from the TF version which uses truncated_normal for initialization
# cf https://github.com/pytorch/pytorch/pull/5617
m.weight.data.normal_(config.initializer_range)
elif isinstance(m, BERTLayerNorm):
m.beta.data.normal_(config.initializer_range)
m.gamma.data.normal_(config.initializer_range)
if isinstance(m, nn.Linear):
m.bias.data.zero_()
module.weight.data.normal_(config.initializer_range)
elif isinstance(module, BERTLayerNorm):
module.beta.data.normal_(config.initializer_range)
module.gamma.data.normal_(config.initializer_range)
if isinstance(module, nn.Linear):
module.bias.data.zero_()
self.apply(init_weights)
def forward(self, input_ids, token_type_ids, attention_mask, labels=None):
@@ -434,16 +434,16 @@ class BertForQuestionAnswering(nn.Module):
# self.dropout = nn.Dropout(config.hidden_dropout_prob)
self.qa_outputs = nn.Linear(config.hidden_size, 2)
def init_weights(m):
if isinstance(m, (nn.Linear, nn.Embedding)):
def init_weights(module):
if isinstance(module, (nn.Linear, nn.Embedding)):
# Slightly different from the TF version which uses truncated_normal for initialization
# cf https://github.com/pytorch/pytorch/pull/5617
m.weight.data.normal_(config.initializer_range)
elif isinstance(m, BERTLayerNorm):
m.beta.data.normal_(config.initializer_range)
m.gamma.data.normal_(config.initializer_range)
if isinstance(m, nn.Linear):
m.bias.data.zero_()
module.weight.data.normal_(config.initializer_range)
elif isinstance(module, BERTLayerNorm):
module.beta.data.normal_(config.initializer_range)
module.gamma.data.normal_(config.initializer_range)
if isinstance(module, nn.Linear):
module.bias.data.zero_()
self.apply(init_weights)
def forward(self, input_ids, token_type_ids, attention_mask, start_positions=None, end_positions=None):
@@ -451,21 +451,13 @@ class BertForQuestionAnswering(nn.Module):
sequence_output = all_encoder_layers[-1]
logits = self.qa_outputs(sequence_output)
start_logits, end_logits = logits.split(1, dim=-1)
start_logits = start_logits.squeeze(-1)
end_logits = end_logits.squeeze(-1)
if start_positions is not None and end_positions is not None:
batch_size, seq_length = input_ids.size()
def compute_loss(logits, positions):
max_position = positions.max().item()
one_hot = torch.FloatTensor(batch_size, max(max_position, seq_length) +1).zero_()
one_hot = one_hot.scatter_(1, positions.cpu(), 1) # Do this on CPU
one_hot = one_hot[:, :seq_length].to(input_ids.device)
log_probs = nn.functional.log_softmax(logits, dim = -1).view(batch_size, seq_length)
loss = -torch.mean(torch.sum(one_hot*log_probs), dim = -1)
return loss
start_loss = compute_loss(start_logits, start_positions)
end_loss = compute_loss(end_logits, end_positions)
loss_fct = CrossEntropyLoss()
start_loss = loss_fct(start_logits, start_positions)
end_loss = loss_fct(end_logits, end_positions)
total_loss = (start_loss + end_loss) / 2
return total_loss, (start_logits, end_logits)
else: