SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

[trainer] improve code readability (#8903)

Browse Source 
* [trainer] improve code

This PR:
- removes redundant code 
```
self.model = model if model is not None else None
```
and
```
self.model = model
```
are the same.

* separate attribute assignment from code logic - which simplifies things further.

* whitespace
This commit is contained in:
Stas Bekman
2020-12-02 09:07:42 -08:00
committed by GitHub
parent a8c3f9aa76
commit 7e1cb00c37
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/transformers/trainer.py
View File

@@ -241,11 +241,12 @@ class Trainer:
self.hp_name = None self.hp_name = None
if model is None and model_init is not None: if model is None and model_init is not None:
model = self.call_model_init() model = self.call_model_init()
# Model parallel # Model parallel
if not self.args.model_parallel: if model is not None and not self.args.model_parallel:
self.model = model.to(args.device) if model is not None else None model = model.to(args.device)
else:
self.model = model if model is not None else None self.model = model
default_collator = default_data_collator if tokenizer is None else DataCollatorWithPadding(tokenizer) default_collator = default_data_collator if tokenizer is None else DataCollatorWithPadding(tokenizer)
self.data_collator = data_collator if data_collator is not None else default_collator self.data_collator = data_collator if data_collator is not None else default_collator
self.train_dataset = train_dataset self.train_dataset = train_dataset