From 7e1cb00c37365c8736f201e5152c741cde41c8b4 Mon Sep 17 00:00:00 2001 From: Stas Bekman Date: Wed, 2 Dec 2020 09:07:42 -0800 Subject: [PATCH] [trainer] improve code readability (#8903) * [trainer] improve code This PR: - removes redundant code ``` self.model = model if model is not None else None ``` and ``` self.model = model ``` are the same. * separate attribute assignment from code logic - which simplifies things further. * whitespace --- src/transformers/trainer.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/transformers/trainer.py b/src/transformers/trainer.py index b678b064c9..90ded12f78 100755 --- a/src/transformers/trainer.py +++ b/src/transformers/trainer.py @@ -241,11 +241,12 @@ class Trainer: self.hp_name = None if model is None and model_init is not None: model = self.call_model_init() + # Model parallel - if not self.args.model_parallel: - self.model = model.to(args.device) if model is not None else None - else: - self.model = model if model is not None else None + if model is not None and not self.args.model_parallel: + model = model.to(args.device) + + self.model = model default_collator = default_data_collator if tokenizer is None else DataCollatorWithPadding(tokenizer) self.data_collator = data_collator if data_collator is not None else default_collator self.train_dataset = train_dataset