From f456b4d10b5c72e0cfe835d3f22a71079c513eb2 Mon Sep 17 00:00:00 2001 From: Joao Gante Date: Wed, 9 Aug 2023 13:07:11 +0100 Subject: [PATCH] Generate: generation config validation fixes in docs (#25405) --- docs/source/en/model_doc/donut.md | 6 ------ src/transformers/generation/configuration_utils.py | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/docs/source/en/model_doc/donut.md b/docs/source/en/model_doc/donut.md index 1e214da8bc..cfbf79972d 100644 --- a/docs/source/en/model_doc/donut.md +++ b/docs/source/en/model_doc/donut.md @@ -80,11 +80,9 @@ into a single instance to both extract the input features and decode the predict ... pixel_values.to(device), ... decoder_input_ids=decoder_input_ids.to(device), ... max_length=model.decoder.config.max_position_embeddings, -... early_stopping=True, ... pad_token_id=processor.tokenizer.pad_token_id, ... eos_token_id=processor.tokenizer.eos_token_id, ... use_cache=True, -... num_beams=1, ... bad_words_ids=[[processor.tokenizer.unk_token_id]], ... return_dict_in_generate=True, ... ) @@ -125,11 +123,9 @@ into a single instance to both extract the input features and decode the predict ... pixel_values.to(device), ... decoder_input_ids=decoder_input_ids.to(device), ... max_length=model.decoder.config.max_position_embeddings, -... early_stopping=True, ... pad_token_id=processor.tokenizer.pad_token_id, ... eos_token_id=processor.tokenizer.eos_token_id, ... use_cache=True, -... num_beams=1, ... bad_words_ids=[[processor.tokenizer.unk_token_id]], ... return_dict_in_generate=True, ... ) @@ -172,11 +168,9 @@ into a single instance to both extract the input features and decode the predict ... pixel_values.to(device), ... decoder_input_ids=decoder_input_ids.to(device), ... max_length=model.decoder.config.max_position_embeddings, -... early_stopping=True, ... pad_token_id=processor.tokenizer.pad_token_id, ... eos_token_id=processor.tokenizer.eos_token_id, ... use_cache=True, -... num_beams=1, ... bad_words_ids=[[processor.tokenizer.unk_token_id]], ... return_dict_in_generate=True, ... ) diff --git a/src/transformers/generation/configuration_utils.py b/src/transformers/generation/configuration_utils.py index 0311684074..6b62a062e4 100644 --- a/src/transformers/generation/configuration_utils.py +++ b/src/transformers/generation/configuration_utils.py @@ -597,7 +597,7 @@ class GenerationConfig(PushToHubMixin): >>> # If you'd like to try a minor variation to an existing configuration, you can also pass generation >>> # arguments to `.from_pretrained()`. Be mindful that typos and unused arguments will be ignored >>> generation_config, unused_kwargs = GenerationConfig.from_pretrained( - ... "gpt2", top_k=1, foo=False, return_unused_kwargs=True + ... "gpt2", top_k=1, foo=False, do_sample=True, return_unused_kwargs=True ... ) >>> generation_config.top_k 1