SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

[testing] fix ambiguous test (#6898)

Browse Source 
Since `generate()` does:
```
        num_beams = num_beams if num_beams is not None else self.config.num_beams
```
This test fails if `model.config.num_beams > 1` (which is the case in the model I'm porting).

This fix makes the test setup unambiguous by passing an explicit `num_beams=1` to `generate()`.

Thanks.
This commit is contained in:
Stas Bekman
2020-09-02 07:18:17 -07:00
committed by GitHub
parent 8f2723caf0
commit e71f32c0ef
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_modeling_common.py
View File

@@ -822,7 +822,7 @@ class ModelTesterMixin:
with self.assertRaises(AssertionError): with self.assertRaises(AssertionError):
# generating multiple sequences when no beam search generation # generating multiple sequences when no beam search generation
# is not allowed as it would always generate the same sequences # is not allowed as it would always generate the same sequences
model.generate(input_ids, do_sample=False, num_return_sequences=2) model.generate(input_ids, do_sample=False, num_beams=1, num_return_sequences=2)
# num_return_sequences > 1, sample # num_return_sequences > 1, sample
self._check_generated_ids(model.generate(input_ids, do_sample=True, num_return_sequences=2)) self._check_generated_ids(model.generate(input_ids, do_sample=True, num_return_sequences=2))