From e4fd5e39993cc2875e3dad536141d5178caaa3f0 Mon Sep 17 00:00:00 2001 From: Bram Vanroy Date: Thu, 7 May 2020 17:14:56 +0200 Subject: [PATCH] Use with_extension to change the extension (#4203) As per https://github.com/huggingface/transformers/pull/3934#discussion_r421307659 --- src/transformers/hf_argparser.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/transformers/hf_argparser.py b/src/transformers/hf_argparser.py index 8bb0ddd57d..560d07b720 100644 --- a/src/transformers/hf_argparser.py +++ b/src/transformers/hf_argparser.py @@ -11,10 +11,6 @@ DataClass = NewType("DataClass", Any) DataClassType = NewType("DataClassType", Any) -def trim_suffix(s: str, suffix: str): - return s if not s.endswith(suffix) or len(suffix) == 0 else s[: -len(suffix)] - - class HfArgumentParser(ArgumentParser): """ This subclass of `argparse.ArgumentParser` uses type hints on dataclasses @@ -109,8 +105,7 @@ class HfArgumentParser(ArgumentParser): (same as argparse.ArgumentParser.parse_known_args) """ if look_for_args_file and len(sys.argv): - basename = trim_suffix(sys.argv[0], ".py") - args_file = Path(f"{basename}.args") + args_file = Path(sys.argv[0]).with_suffix(".args") if args_file.exists(): fargs = args_file.read_text().split() args = fargs + args if args is not None else fargs + sys.argv[1:]