SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

[code quality] fix confused flake8 (#7309)

Browse Source 
* fix confused flake

We run `black  --target-version py35 ...` but flake8 doesn't know that, so currently with py38 flake8 fails suggesting that black should have reformatted 63 files. Indeed if I run:

```
black --line-length 119 --target-version py38 examples templates tests src utils
```
it indeed reformats 63 files.

The only solution I found is to create a black config file as explained at https://github.com/psf/black#configuration-format, which is what this PR adds.

Now flake8 knows that py35 is the standard and no longer gets confused regardless of the user's python version.

* adjust the other files that will now rely on black's config file
This commit is contained in:
Stas Bekman
2020-09-22 19:12:36 -07:00
committed by GitHub
parent 78387cc63e
commit df53643807
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.circleci/config.yml
View File

@@ -244,7 +244,7 @@ jobs:
key: v0.3-code_quality-{{ checksum "setup.py" }} key: v0.3-code_quality-{{ checksum "setup.py" }}
paths: paths:
- '~/.cache/pip' - '~/.cache/pip'
- run: black --check --line-length 119 --target-version py35 examples templates tests src utils - run: black --check examples templates tests src utils
- run: isort --check-only examples templates tests src utils - run: isort --check-only examples templates tests src utils
- run: flake8 examples templates tests src utils - run: flake8 examples templates tests src utils
- run: python utils/check_copies.py - run: python utils/check_copies.py

4
Makefile
View File

@@ -3,7 +3,7 @@
# Check that source code meets quality standards # Check that source code meets quality standards
quality: quality:
black --check --line-length 119 --target-version py35 examples templates tests src utils black --check examples templates tests src utils
isort --check-only examples templates tests src utils isort --check-only examples templates tests src utils
flake8 examples templates tests src utils flake8 examples templates tests src utils
python utils/check_copies.py python utils/check_copies.py
@@ -12,7 +12,7 @@ quality:
# Format source code automatically # Format source code automatically
style: style:
black --line-length 119 --target-version py35 examples templates tests src utils black examples templates tests src utils
isort examples templates tests src utils isort examples templates tests src utils
# Make marked copies of snippets of codes conform to the original # Make marked copies of snippets of codes conform to the original

3
pyproject.toml Normal file
View File

@@ -0,0 +1,3 @@
[tool.black]
line-length = 119
target-version = ['py35']