SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Make sure telemetry arguments are not returned as unused kwargs (#17063)

Browse Source 
* Make sure telemetry arguments are not returned as unused kwargs

* Fix test
This commit is contained in:
Sylvain Gugger
2022-05-04 07:47:57 -04:00
committed by GitHub
parent 675e2d1663
commit d76d2a2af7
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/transformers/configuration_utils.py
View File

@@ -676,6 +676,10 @@ class PretrainedConfig(PushToHubMixin):
[`PretrainedConfig`]: The configuration object instantiated from those parameters. [`PretrainedConfig`]: The configuration object instantiated from those parameters.
""" """
return_unused_kwargs = kwargs.pop("return_unused_kwargs", False) return_unused_kwargs = kwargs.pop("return_unused_kwargs", False)
# Those arguments may be passed along for our internal telemetry.
# We remove them so they don't appear in `return_unused_kwargs`.
kwargs.pop("_from_auto", None)
kwargs.pop("_from_pipeline", None)
config = cls(**config_dict) config = cls(**config_dict)

2
tests/test_configuration_common.py
View File

@@ -356,7 +356,7 @@ class ConfigurationVersioningTest(unittest.TestCase):
) )
self.assertEqual(new_configuration.hidden_size, 2) self.assertEqual(new_configuration.hidden_size, 2)
# This checks `_configuration_file` ia not kept in the kwargs by mistake. # This checks `_configuration_file` ia not kept in the kwargs by mistake.
self.assertDictEqual(kwargs, {"_from_auto": True}) self.assertDictEqual(kwargs, {})
# Testing an older version by monkey-patching the version in the module it's used. # Testing an older version by monkey-patching the version in the module it's used.
import transformers as old_transformers import transformers as old_transformers