From d039c679d21ff38182b6c0d18757682f5f50d2aa Mon Sep 17 00:00:00 2001 From: patrickvonplaten Date: Mon, 23 Dec 2019 23:39:16 +0100 Subject: [PATCH] better naming for if statement --- src/transformers/modeling_utils.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py index c727bb5f2e..e5e4926af9 100644 --- a/src/transformers/modeling_utils.py +++ b/src/transformers/modeling_utils.py @@ -542,7 +542,11 @@ class PreTrainedModel(nn.Module): def _do_output_past(self, outputs): # TODO: might be better to write a self.do_output_past method for each individual class as is done for # prepare_inputs_for_generation - if hasattr(self.config, 'output_past') and self.config.output_past and len(outputs) > 1 and not hasattr(self, 'mem_len'): + has_output_past = hasattr(self.config, 'output_past') and self.config.output_past + has_multiple_outputs = len(outputs) > 1 + has_mem_len = hasattr(self, 'mem_len') + + if has_output_past and has_multiple_outputs and not has_mem_len: return True # TODO: Add cases for (xlnet, transfo_xl) using mem_len return False