From ced7284a60dda0a8a2cac2b712e61a1739e08b37 Mon Sep 17 00:00:00 2001 From: Philipp Schmid <32632186+philschmid@users.noreply.github.com> Date: Wed, 31 Mar 2021 13:44:22 +0200 Subject: [PATCH] Sagemaker test fix (#10987) * wrong makefile command * ddp test fix --- tests/sagemaker/README.md | 4 ++-- tests/sagemaker/test_multi_node_data_parallel.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/sagemaker/README.md b/tests/sagemaker/README.md index 12e2f8d890..b3c9906cc5 100644 --- a/tests/sagemaker/README.md +++ b/tests/sagemaker/README.md @@ -18,7 +18,7 @@ git+https://github.com/huggingface/transformers.git@v4.5.0.rc0 # install master After we adjusted the `requirements.txt` we can run Amazon SageMaker tests with: ```bash -AWS_PROFILE= make sagemaker-test +AWS_PROFILE= make test-sagemaker ``` These tests take around 10-15 minutes to finish. Preferably make a screenshot of the successfully ran tests. @@ -88,7 +88,7 @@ tensorflow-gpu==2.5.0 # for tensorflow After we adjusted the `requirements.txt` we can run Amazon SageMaker tests with. ```bash -AWS_PROFILE= make sagemaker-test +AWS_PROFILE= make test-sagemaker ``` These tests take around 10-15 minutes to finish. Preferably make a screenshot of the successfully ran tests. diff --git a/tests/sagemaker/test_multi_node_data_parallel.py b/tests/sagemaker/test_multi_node_data_parallel.py index 460465606c..67d8dcd70d 100644 --- a/tests/sagemaker/test_multi_node_data_parallel.py +++ b/tests/sagemaker/test_multi_node_data_parallel.py @@ -58,7 +58,7 @@ class MultiNodeTest(unittest.TestCase): def create_estimator(self, instance_count): job_name = f"{self.env.base_job_name}-{instance_count}-{'ddp' if 'ddp' in self.script else 'smd'}" # distributed data settings - distribution = {"smdistributed": {"dataparallel": {"enabled": True}}} + distribution = {"smdistributed": {"dataparallel": {"enabled": True}}} if self.script != "run_ddp.py" else None # creates estimator return HuggingFace(