[trainer] sanity checks for save_steps=0|None and logging_steps=0 (#12796)

* [trainer] fix % 0 * sanity checks * fix logging_strategy * correction * Update src/transformers/training_args.py Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
2021-07-20 09:05:26 -07:00
parent acdd78db08
commit cabcc75171
3 changed files with 16 additions and 7 deletions
--- a/tests/extended/test_trainer_ext.py
+++ b/tests/extended/test_trainer_ext.py
@@ -248,6 +248,7 @@ class TestTrainerExt(TestCasePlus):
            --learning_rate {learning_rate}
            --warmup_steps 8
            --logging_steps 0
+            --logging_strategy no
            --save_steps {str(eval_steps)}
            --group_by_length
            --label_smoothing_factor 0.1