From ca37db0559f928db42b97af4b6dd8f7d0fb2ac11 Mon Sep 17 00:00:00 2001 From: Stas Bekman Date: Tue, 20 Oct 2020 04:55:40 -0700 Subject: [PATCH] [flax] fix repo_check (#7914) * [flax] fix repo_check Unless, this is actually a problem, this adds `modeling_flax_utils` to ignore list. otherwise currently it expects to have a 'tests/test_modeling_flax_utils.py' for it. for context please see: https://github.com/huggingface/transformers/pull/3722#issuecomment-712360415 * fix 2 more issues * merge https://github.com/huggingface/transformers/pull/7919/ --- .circleci/config.yml | 2 +- utils/check_repo.py | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 80d0366ea4..7e1acdd6fb 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -264,7 +264,7 @@ jobs: - v0.3-{{ checksum "setup.py" }} - run: pip install --upgrade pip - run: pip install isort - - run: pip install .[tf,torch,quality] + - run: pip install .[tf,torch,flax,quality] - save_cache: key: v0.3-code_quality-{{ checksum "setup.py" }} paths: diff --git a/utils/check_repo.py b/utils/check_repo.py index a0ade81f91..69dfd9ef0d 100644 --- a/utils/check_repo.py +++ b/utils/check_repo.py @@ -41,12 +41,14 @@ IGNORE_NON_TESTED = [ # trigger the common tests. TEST_FILES_WITH_NO_COMMON_TESTS = [ "test_modeling_camembert.py", + "test_modeling_flax_bert.py", + "test_modeling_flax_roberta.py", + "test_modeling_mbart.py", + "test_modeling_pegasus.py", "test_modeling_tf_camembert.py", "test_modeling_tf_xlm_roberta.py", "test_modeling_xlm_prophetnet.py", "test_modeling_xlm_roberta.py", - "test_modeling_pegasus.py", - "test_modeling_mbart.py", ] # Update this list for models that are not documented with a comment explaining the reason it should not be. @@ -88,6 +90,7 @@ def get_model_modules(): "modeling_outputs", "modeling_retribert", "modeling_utils", + "modeling_flax_utils", "modeling_transfo_xl_utilities", "modeling_tf_auto", "modeling_tf_outputs",