SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Fix default bool in argparser (#12424)

Browse Source 
* Fix default bool in argparser

* Add more to test
This commit is contained in:
Sylvain Gugger
2021-06-30 07:57:05 -04:00
committed by GitHub
parent 90d69456eb
commit c9486fd0f5
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/transformers/hf_argparser.py
View File

@@ -112,8 +112,8 @@ class HfArgumentParser(ArgumentParser):
# Hack because type=bool in argparse does not behave as we want. # Hack because type=bool in argparse does not behave as we want.
kwargs["type"] = string_to_bool kwargs["type"] = string_to_bool
if field.type is bool or (field.default is not None and field.default is not dataclasses.MISSING): if field.type is bool or (field.default is not None and field.default is not dataclasses.MISSING):
# Default value is True if we have no default when of type bool. # Default value is False if we have no default when of type bool.
default = True if field.default is dataclasses.MISSING else field.default default = False if field.default is dataclasses.MISSING else field.default
# This is the value that will get picked if we don't include --field_name in any way # This is the value that will get picked if we don't include --field_name in any way
kwargs["default"] = default kwargs["default"] = default
# This tells argparse we accept 0 or 1 value after --field_name # This tells argparse we accept 0 or 1 value after --field_name

6
tests/test_hf_argparser.py
View File

@@ -106,9 +106,13 @@ class HfArgumentParserTest(unittest.TestCase):
expected.add_argument("--foo", type=int, required=True) expected.add_argument("--foo", type=int, required=True)
expected.add_argument("--bar", type=float, required=True) expected.add_argument("--bar", type=float, required=True)
expected.add_argument("--baz", type=str, required=True) expected.add_argument("--baz", type=str, required=True)
expected.add_argument("--flag", type=string_to_bool, default=True, const=True, nargs="?") expected.add_argument("--flag", type=string_to_bool, default=False, const=True, nargs="?")
self.argparsersEqual(parser, expected) self.argparsersEqual(parser, expected)
args = ["--foo", "1", "--baz", "quux", "--bar", "0.5"]
(example,) = parser.parse_args_into_dataclasses(args, look_for_args_file=False)
self.assertFalse(example.flag)
def test_with_default(self): def test_with_default(self):
parser = HfArgumentParser(WithDefaultExample) parser = HfArgumentParser(WithDefaultExample)