From c1357834e86e71792d1cad06a998f5ebf6e07126 Mon Sep 17 00:00:00 2001
From: Pablo Montalvo <39954772+molbap@users.noreply.github.com>
Date: Tue, 13 Aug 2024 23:40:50 +0200
Subject: [PATCH] Fix tests recurrent (#32651)

* add fix for recurrentgemma

* [no-filter]

* trigger-ci

* [no-filter]

* [no-filter]

* attempt to fix mysterious zip error

* [no-filter]

* fix lookup error

* [no-filter]

* remove summarization hack

* [no-filter]
---
 tests/test_modeling_common.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/test_modeling_common.py b/tests/test_modeling_common.py
index 203146a808..b5bad16a02 100755
--- a/tests/test_modeling_common.py
+++ b/tests/test_modeling_common.py
@@ -2829,8 +2829,8 @@ class ModelTesterMixin:
             model.eval()
 
             model_forward_args = inspect.signature(model.forward).parameters
-            if "inputs_embeds" not in model_forward_args:
-                self.skipTest(reason="This model doesn't use `inputs_embeds`")
+            if any(argument not in model_forward_args for argument in ["inputs_embeds", "position_ids"]):
+                self.skipTest(reason="This model doesn't use `inputs_embeds` or `position_ids`.")
             has_inputs_embeds_forwarding = "inputs_embeds" in set(
                 inspect.signature(model.prepare_inputs_for_generation).parameters.keys()
             )