use torch.testing.assertclose instead to get more details about error in cis (#35659)
* use torch.testing.assertclose instead to get more details about error in cis * fix * style * test_all * revert for I bert * fixes and updates * more image processing fixes * more image processors * fix mamba and co * style * less strick * ok I won't be strict * skip and be done * up
This commit is contained in:
@@ -360,14 +360,14 @@ class CoreIntegrationDeepSpeed(TestCasePlus, TrainerIntegrationCommon):
|
||||
model.config.max_position_embeddings, model.config.rotary_dim
|
||||
)
|
||||
self.assertFalse(torch.allclose(good_deepspeed_sin_cos, bad_deepspeed_sin_cos))
|
||||
self.assertTrue(torch.allclose(good_torch_sin_cos, good_deepspeed_sin_cos.cpu()))
|
||||
torch.testing.assert_close(good_torch_sin_cos, good_deepspeed_sin_cos.cpu())
|
||||
|
||||
# Finally, we can see that the incorrect pattern is okay on vanilla torch, demostrating that this issue is
|
||||
# exclusive to DeepSpeed
|
||||
bad_torch_sin_cos = bad_deepspeed_create_sinusoidal_positions(
|
||||
model.config.max_position_embeddings, model.config.rotary_dim
|
||||
)
|
||||
self.assertTrue(torch.allclose(bad_torch_sin_cos, good_torch_sin_cos))
|
||||
torch.testing.assert_close(bad_torch_sin_cos, good_torch_sin_cos)
|
||||
|
||||
|
||||
class TrainerIntegrationDeepSpeedWithCustomConfig(TestCasePlus):
|
||||
|
||||
Reference in New Issue
Block a user