Un-deprecate timeout arg in pipelines (#34382)

* Un-deprecate timeout

* Put "timeout" on the allowed list

* make fixup
This commit is contained in:
Matt
2024-10-29 18:45:14 +00:00
committed by GitHub
parent e4449bb790
commit 9bee9ff5db
7 changed files with 27 additions and 23 deletions

View File

@@ -916,6 +916,8 @@ def parse_args_from_docstring_by_indentation(docstring):
def compare_pipeline_args_to_hub_spec(pipeline_class, hub_spec):
ALLOWED_TRANSFORMERS_ONLY_ARGS = ["timeout"]
docstring = inspect.getdoc(pipeline_class.__call__).strip()
docstring_args = set(parse_args_from_docstring_by_indentation(docstring))
hub_args = set(get_arg_names_from_hub_spec(hub_spec))
@@ -933,6 +935,11 @@ def compare_pipeline_args_to_hub_spec(pipeline_class, hub_spec):
hub_args.remove(js_generate_args[0])
docstring_args.remove(docstring_generate_args[0])
# Special casing 2: We permit some transformers-only arguments that don't affect pipeline output
for arg in ALLOWED_TRANSFORMERS_ONLY_ARGS:
if arg in docstring_args and arg not in hub_args:
docstring_args.remove(arg)
if hub_args != docstring_args:
error = [f"{pipeline_class.__name__} differs from JS spec {hub_spec.__name__}"]
matching_args = hub_args & docstring_args