[cleanup] assign todos, faster bart-cnn test (#7835)

* 2 beam output

* unassign/remove TODOs

* remove one more
This commit is contained in:
Sam Shleifer
2020-10-16 03:11:18 -04:00
committed by GitHub
parent 7b13bd01df
commit 96e47d9229
8 changed files with 29 additions and 54 deletions

View File

@@ -291,7 +291,8 @@ class LoggingCallback(pl.Callback):
def add_generic_args(parser, root_dir) -> None:
# TODO(SS): allow all pl args? parser = pl.Trainer.add_argparse_args(parser)
# To allow all pl args uncomment the following line
# parser = pl.Trainer.add_argparse_args(parser)
parser.add_argument(
"--output_dir",
default=None,