From 89b00eef9428111cd7c48426905fe013d7047a3b Mon Sep 17 00:00:00 2001 From: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> Date: Wed, 7 Jun 2023 11:38:56 -0400 Subject: [PATCH] Fix expected value in tests of the test fetcher (#24077) * Fix expected value in tests of the test fetcher * Fix trigger for repo util tests --- tests/repo_utils/test_tests_fetcher.py | 13 ++++++++++--- utils/tests_fetcher.py | 8 ++++++-- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/tests/repo_utils/test_tests_fetcher.py b/tests/repo_utils/test_tests_fetcher.py index 2dfc671944..a897bb3f0d 100644 --- a/tests/repo_utils/test_tests_fetcher.py +++ b/tests/repo_utils/test_tests_fetcher.py @@ -526,10 +526,17 @@ src/transformers/configuration_utils.py create_tmp_repo(tmp_folder) expected_example_deps = { - "examples/flax/test_flax_examples.py": ["examples/flax/text-classification/run_glue.py"], - "examples/pytorch/test_pytorch_examples.py": ["examples/pytorch/text-classification/run_glue.py"], + "examples/flax/test_flax_examples.py": [ + "examples/flax/text-classification/run_glue.py", + "examples/flax/test_flax_examples.py", + ], + "examples/pytorch/test_pytorch_examples.py": [ + "examples/pytorch/text-classification/run_glue.py", + "examples/pytorch/test_pytorch_examples.py", + ], "examples/tensorflow/test_tensorflow_examples.py": [ - "examples/tensorflow/text-classification/run_glue.py" + "examples/tensorflow/text-classification/run_glue.py", + "examples/tensorflow/test_tensorflow_examples.py", ], } diff --git a/utils/tests_fetcher.py b/utils/tests_fetcher.py index 44b1b1f10b..a06a2f672f 100644 --- a/utils/tests_fetcher.py +++ b/utils/tests_fetcher.py @@ -353,7 +353,9 @@ def extract_imports(module_fname, cache=None): content = f.read() # Filter out all docstrings to not get imports in code examples. - splits = content.split('"""') + # fmt: off + splits = content.split('\"\"\"') + # fmt: on content = "".join(splits[::2]) module_parts = str(module_fname).split(os.path.sep) @@ -694,12 +696,14 @@ def infer_tests_to_run(output_file, diff_with_last_commit=False, filter_models=T if f in test_map: test_files_to_run.extend(test_map[f]) test_files_to_run = sorted(set(test_files_to_run)) + # Remove repo utils tests + test_files_to_run = [f for f in test_files_to_run if not f.split(os.path.sep)[1] == "repo_utils"] # Remove SageMaker tests test_files_to_run = [f for f in test_files_to_run if not f.split(os.path.sep)[1] == "sagemaker"] # Make sure we did not end up with a test file that was removed test_files_to_run = [f for f in test_files_to_run if (PATH_TO_REPO / f).exists()] - repo_utils_launch = any(f.split(os.path.sep)[1] == "repo_utils" for f in modified_files) + repo_utils_launch = any(f.split(os.path.sep)[0] == "utils" for f in modified_files) if repo_utils_launch: repo_util_file = Path(output_file).parent / "test_repo_utils.txt"