From 88912b8e958b88eae3a9456ea1e09c336a52462c Mon Sep 17 00:00:00 2001
From: Sai-Suraj-27 <sai.suraj.27.729@gmail.com>
Date: Thu, 5 Jun 2025 22:12:49 +0530
Subject: [PATCH] Remove `isort` from dependencies (#38616)

Removed isort as a dependency
---
 setup.py                                      | 3 +--
 src/transformers/dependency_versions_table.py | 1 -
 src/transformers/trainer.py                   | 4 ++--
 tests/tokenization/test_tokenization_utils.py | 2 +-
 4 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/setup.py b/setup.py
index 12347c14a5..04942c88b4 100644
--- a/setup.py
+++ b/setup.py
@@ -120,7 +120,6 @@ _deps = [
     "huggingface-hub>=0.30.0,<1.0",
     "importlib_metadata",
     "ipadic>=1.0.0,<2.0",
-    "isort>=5.5.4",
     "jax>=0.4.1,<=0.4.13",
     "jaxlib>=0.4.1,<=0.4.13",
     "jieba",
@@ -368,7 +367,7 @@ extras["testing"] = (
 
 extras["deepspeed-testing"] = extras["deepspeed"] + extras["testing"] + extras["optuna"] + extras["sentencepiece"]
 extras["ruff"] = deps_list("ruff")
-extras["quality"] = deps_list("datasets", "isort", "ruff", "GitPython", "urllib3", "libcst", "rich", "pandas")
+extras["quality"] = deps_list("datasets", "ruff", "GitPython", "urllib3", "libcst", "rich", "pandas")
 
 extras["all"] = (
     extras["tf"]
diff --git a/src/transformers/dependency_versions_table.py b/src/transformers/dependency_versions_table.py
index f5282f9fd3..70cb07440f 100644
--- a/src/transformers/dependency_versions_table.py
+++ b/src/transformers/dependency_versions_table.py
@@ -27,7 +27,6 @@ deps = {
     "huggingface-hub": "huggingface-hub>=0.30.0,<1.0",
     "importlib_metadata": "importlib_metadata",
     "ipadic": "ipadic>=1.0.0,<2.0",
-    "isort": "isort>=5.5.4",
     "jax": "jax>=0.4.1,<=0.4.13",
     "jaxlib": "jaxlib>=0.4.1,<=0.4.13",
     "jieba": "jieba",
diff --git a/src/transformers/trainer.py b/src/transformers/trainer.py
index ca8263cb3f..ca03db9947 100755
--- a/src/transformers/trainer.py
+++ b/src/transformers/trainer.py
@@ -38,12 +38,12 @@ from typing import TYPE_CHECKING, Any, Callable, Optional, Union
 
 
 # Integrations must be imported before ML frameworks:
-# isort: off
+# ruff: isort: off
 from .integrations import (
     get_reporting_integration_callbacks,
 )
 
-# isort: on
+# ruff: isort: on
 
 import huggingface_hub.utils as hf_hub_utils
 import numpy as np
diff --git a/tests/tokenization/test_tokenization_utils.py b/tests/tokenization/test_tokenization_utils.py
index 550d319d9b..ce70863c34 100644
--- a/tests/tokenization/test_tokenization_utils.py
+++ b/tests/tokenization/test_tokenization_utils.py
@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 """
-isort:skip_file
+ruff: isort: skip_file
 """
 
 import os