From 7bc00569df137296e8e4d4eb3ff585c431771c30 Mon Sep 17 00:00:00 2001 From: Kevin Canwen Xu Date: Fri, 14 Aug 2020 00:34:03 +0800 Subject: [PATCH] Clean directory after script testing (#6453) * Clean Dir after testing * remove pabee ignore --- examples/bert-loses-patience/test_run_glue_with_pabee.py | 8 +++++++- examples/test_examples.py | 9 +++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/examples/bert-loses-patience/test_run_glue_with_pabee.py b/examples/bert-loses-patience/test_run_glue_with_pabee.py index 0b726b1e69..bce1854494 100644 --- a/examples/bert-loses-patience/test_run_glue_with_pabee.py +++ b/examples/bert-loses-patience/test_run_glue_with_pabee.py @@ -1,5 +1,6 @@ import argparse import logging +import shutil import sys import unittest from unittest.mock import patch @@ -19,8 +20,11 @@ def get_setup_file(): return args.f +def clean_test_dir(path="./tests/fixtures/tests_samples/temp_dir"): + shutil.rmtree(path, ignore_errors=True) + + class PabeeTests(unittest.TestCase): - @unittest.skip("Disable while Canwen investigates.") def test_run_glue(self): stream_handler = logging.StreamHandler(sys.stdout) logger.addHandler(stream_handler) @@ -47,3 +51,5 @@ class PabeeTests(unittest.TestCase): result = run_glue_with_pabee.main() for value in result.values(): self.assertGreaterEqual(value, 0.75) + + clean_test_dir() diff --git a/examples/test_examples.py b/examples/test_examples.py index bb65a6ba56..aa7af4bf2c 100644 --- a/examples/test_examples.py +++ b/examples/test_examples.py @@ -17,6 +17,7 @@ import argparse import logging import os +import shutil import sys import unittest from unittest.mock import patch @@ -51,6 +52,10 @@ def get_setup_file(): return args.f +def clean_test_dir(path="./tests/fixtures/tests_samples/temp_dir"): + shutil.rmtree(path, ignore_errors=True) + + class ExamplesTests(unittest.TestCase): def test_run_glue(self): stream_handler = logging.StreamHandler(sys.stdout) @@ -78,6 +83,7 @@ class ExamplesTests(unittest.TestCase): del result["eval_loss"] for value in result.values(): self.assertGreaterEqual(value, 0.75) + clean_test_dir() def test_run_pl_glue(self): stream_handler = logging.StreamHandler(sys.stdout) @@ -113,6 +119,7 @@ class ExamplesTests(unittest.TestCase): # for k, v in result.items(): # self.assertGreaterEqual(v, 0.75, f"({k})") # + clean_test_dir() def test_run_language_modeling(self): stream_handler = logging.StreamHandler(sys.stdout) @@ -136,6 +143,7 @@ class ExamplesTests(unittest.TestCase): with patch.object(sys, "argv", testargs): result = run_language_modeling.main() self.assertLess(result["perplexity"], 35) + clean_test_dir() def test_run_squad(self): stream_handler = logging.StreamHandler(sys.stdout) @@ -162,6 +170,7 @@ class ExamplesTests(unittest.TestCase): result = run_squad.main() self.assertGreaterEqual(result["f1"], 25) self.assertGreaterEqual(result["exact"], 21) + clean_test_dir() def test_generation(self): stream_handler = logging.StreamHandler(sys.stdout)