SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Test fetcher: missing return on filtered tests; don't write empty files (#33224)

Browse Source 
* missing return

* skip files without contents

* test 2

* dbg

* dbg

* how about this?
This commit is contained in:
Joao Gante
2024-08-30 23:41:52 +01:00
committed by GitHub
parent 51e6526b38
commit 746104ba6f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
utils/tests_fetcher.py
View File

@@ -979,6 +979,7 @@ def create_module_to_test_map(
or "/".join(Path(t).parts[1:3]) in module or "/".join(Path(t).parts[1:3]) in module
): ):
filtered_tests += [t] filtered_tests += [t]
return filtered_tests
return { return {
module: (filter_tests(tests, module=module) if has_many_models(tests) else tests) module: (filter_tests(tests, module=module) if has_many_models(tests) else tests)
@@ -1159,8 +1160,9 @@ def create_test_list_from_filter(full_test_list, out_path):
else: else:
files_to_test = list(re.findall(_filter, all_test_files)) files_to_test = list(re.findall(_filter, all_test_files))
print(job_name, file_name) print(job_name, file_name)
with open(file_name, "w") as f: if len(files_to_test) > 0: # No tests -> no file with test list
f.write("\n".join(files_to_test)) with open(file_name, "w") as f:
f.write("\n".join(files_to_test))
if __name__ == "__main__": if __name__ == "__main__":