From 6f0ce527606bff840abe1e255927710232ccaded Mon Sep 17 00:00:00 2001 From: Joao Gante Date: Thu, 3 Oct 2024 12:27:02 +0100 Subject: [PATCH] VLM Generate: tag `test_static_cache_matches_dynamic` as flaky (#33630) flaky --- tests/test_modeling_common.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_modeling_common.py b/tests/test_modeling_common.py index 4d96b22928..705631a460 100755 --- a/tests/test_modeling_common.py +++ b/tests/test_modeling_common.py @@ -4714,6 +4714,7 @@ class ModelTesterMixin: normalized_1 = F.softmax(out_shared_prefix_last_tokens) torch.testing.assert_close(normalized_0, normalized_1, rtol=1e-3, atol=1e-4) + @is_flaky(max_attempts=10) # TODO @raushan: this test is VERY flaky on some VLMs, like paligemma def test_static_cache_matches_dynamic(self): """ Tests that generating with static cache give almost same results as with dynamic cache. @@ -4749,7 +4750,7 @@ class ModelTesterMixin: output_logits=True, return_dict_in_generate=True, ) - self.assertTrue(torch.allclose(dynamic_out.logits[0], static_out.logits[0], rtol=1e-3, atol=1e-3)) + self.assertTrue(torch.allclose(dynamic_out.logits[0], static_out.logits[0], rtol=1e-3, atol=1e-4)) # For now, Let's focus only on GPU for `torch.compile` @slow