SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Empty assert hunt (#6056)

Browse Source 
* Fixed empty asserts

* black-reformatted stragglers in templates

* More code quality checks

* Update src/transformers/convert_marian_to_pytorch.py

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>

* Update src/transformers/convert_marian_to_pytorch.py

Co-authored-by: Sam Shleifer <sshleifer@gmail.com>

* removed unused line as per @sshleifer

Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Co-authored-by: Sam Shleifer <sshleifer@gmail.com>
This commit is contained in:
Teven
2020-08-03 10:19:03 +02:00
committed by GitHub
parent 16c2240164
commit 5a0dac53bf
26 changed files with 131 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
templates/adding_a_new_example_script/utils_xxx.py
View File

@@ -327,9 +327,15 @@ def convert_examples_to_features(
segment_ids.append(pad_token_segment_id)
p_mask.append(1)
assert len(input_ids) == max_seq_length
assert len(input_mask) == max_seq_length
assert len(segment_ids) == max_seq_length
assert (
len(input_ids) == max_seq_length
), f"Input ids and sequence have mismatched lengths {len(input_ids)} and {max_seq_length}"
assert (
len(input_mask) == max_seq_length
), f"Input mask and sequence have mismatched lengths {len(input_mask)} and {max_seq_length}"
assert (
len(segment_ids) == max_seq_length
), f"Segment ids and sequence have mismatched lengths {len(segment_ids)} and {max_seq_length}"
span_is_impossible = example.is_impossible
start_position = None
@@ -626,7 +632,7 @@ def write_predictions(
if not nbest:
nbest.append(_NbestPrediction(text="empty", start_logit=0.0, end_logit=0.0))
assert len(nbest) >= 1
assert len(nbest) >= 1, "No valid predictions"
total_scores = []
best_non_null_entry = None
@@ -647,7 +653,7 @@ def write_predictions(
output["end_logit"] = entry.end_logit
nbest_json.append(output)
assert len(nbest_json) >= 1
assert len(nbest_json) >= 1, "No valid predictions"
if not version_2_with_negative:
all_predictions[example.qas_id] = nbest_json[0]["text"]
@@ -843,8 +849,8 @@ def write_predictions_extended(
output["end_log_prob"] = entry.end_log_prob
nbest_json.append(output)
assert len(nbest_json) >= 1
assert best_non_null_entry is not None
assert len(nbest_json) >= 1, "No valid predictions"
assert best_non_null_entry is not None, "No valid predictions"
score_diff = score_null
scores_diff_json[example.qas_id] = score_diff