From 569a97adb2bdfecf8549c6f18781eda3e898b046 Mon Sep 17 00:00:00 2001 From: Yih-Dar <2521628+ydshieh@users.noreply.github.com> Date: Mon, 15 May 2023 14:28:36 +0200 Subject: [PATCH] Revert "Only add files with modification outside doc blocks" (#23371) fix Co-authored-by: ydshieh --- utils/tests_fetcher.py | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/utils/tests_fetcher.py b/utils/tests_fetcher.py index 9cb6dd4f8b..8aa1015f39 100644 --- a/utils/tests_fetcher.py +++ b/utils/tests_fetcher.py @@ -225,23 +225,10 @@ def get_diff_for_py_and_mdx_files(repo, base_commit, commits): for commit in commits: for diff_obj in commit.diff(base_commit): # We always add new python files - if diff_obj.change_type in ["A"] and (diff_obj.b_path.endswith(".py") or diff_obj.b_path.endswith(".mdx")): - code_diff.append(diff_obj.b_path) - # Now for modified files - elif ( - diff_obj.change_type in ["M", "R"] - and diff_obj.b_path.endswith(".py") - or diff_obj.b_path.endswith(".mdx") + if diff_obj.change_type in ["A", "M", "R"] and ( + diff_obj.b_path.endswith(".py") or diff_obj.b_path.endswith(".mdx") ): - # In case of renames, we'll look at the tests using both the old and new name. - if diff_obj.a_path != diff_obj.b_path: - code_diff.extend([diff_obj.a_path, diff_obj.b_path]) - else: - # Otherwise, we check modifications are in code and not docstrings. - if diff_is_docstring_only(repo, commit, diff_obj.b_path): - print(f"Ignoring diff in {diff_obj.b_path} as it only concerns docstrings or comments.") - else: - code_diff.append(diff_obj.a_path) + code_diff.append(diff_obj.b_path) return code_diff