From 49006d0662e3d1ed45610205d9b7fc17f2c00679 Mon Sep 17 00:00:00 2001 From: Tim Rault Date: Fri, 2 Nov 2018 10:04:41 +0100 Subject: [PATCH] Bug fix type=bool -> action='store_true' in argparse --- create_pretraining_data_pytorch.py | 2 +- run_pretraining_pytorch.py | 6 +++--- run_squad_pytorch.py | 4 ++-- tokenization_test_pytorch.py | 3 +-- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/create_pretraining_data_pytorch.py b/create_pretraining_data_pytorch.py index c3f8f84c80..1068bddaff 100644 --- a/create_pretraining_data_pytorch.py +++ b/create_pretraining_data_pytorch.py @@ -37,7 +37,7 @@ parser.add_argument("--vocab_file", default=None, type=str, required=True, help="The vocabulary file that the BERT model was trained on.") ## Other parameters -parser.add_argument("--do_lower_case", default=True, type=bool, +parser.add_argument("--do_lower_case", default=True, action='store_true', help="Whether to lower case the input text. Should be True for uncased " "models and False for cased models.") parser.add_argument("--max_seq_length", default=128, type=int, help="Maximum sequence length.") diff --git a/run_pretraining_pytorch.py b/run_pretraining_pytorch.py index 6403ee4037..071035a49c 100644 --- a/run_pretraining_pytorch.py +++ b/run_pretraining_pytorch.py @@ -44,8 +44,8 @@ parser.add_argument("--max_seq_length", default=128, type=int, "Must match data generation.") parser.add_argument("--max_predictions_per_seq", default=20, type=int, help="Maximum number of masked LM predictions per sequence. Must match data generation.") -parser.add_argument("--do_train", default=False, type=bool, help="Whether to run training.") -parser.add_argument("--do_eval", default=False, type=bool, help="Whether to run eval on the dev set.") +parser.add_argument("--do_train", default=False, action='store_true', help="Whether to run training.") +parser.add_argument("--do_eval", default=False, action='store_true', help="Whether to run eval on the dev set.") parser.add_argument("--train_batch_size", default=32, type=int, help="Total batch size for training.") parser.add_argument("--eval_batch_size", default=8, type=int, help="Total batch size for eval.") parser.add_argument("--learning_rate", default=5e-5, type=float, help="The initial learning rate for Adam.") @@ -56,7 +56,7 @@ parser.add_argument("--iterations_per_loop", default=1000, type=int, help="How many steps to make in each estimator call.") parser.add_argument("--max_eval_steps", default=100, type=int, help="Maximum number of eval steps.") ### BEGIN - TO DELETE EVENTUALLY --> NO SENSE IN PYTORCH ### -parser.add_argument("--use_tpu", default=False, type=bool, help="Whether to use TPU or GPU/CPU.") +parser.add_argument("--use_tpu", default=False, action='store_true', help="Whether to use TPU or GPU/CPU.") parser.add_argument("--tpu_name", default=None, type=str, help="The Cloud TPU to use for training. This should be either the name used when creating the " "Cloud TPU, or a grpc://ip.address.of.tpu:8470 url.") diff --git a/run_squad_pytorch.py b/run_squad_pytorch.py index b37bee996d..d24673a073 100644 --- a/run_squad_pytorch.py +++ b/run_squad_pytorch.py @@ -86,7 +86,7 @@ parser.add_argument("--max_answer_length", default=30, type=int, "and end predictions are not conditioned on one another.") ### BEGIN - TO DELETE EVENTUALLY --> NO SENSE IN PYTORCH ### -# parser.add_argument("--use_tpu", default=False, type=bool, help="Whether to use TPU or GPU/CPU.") +# parser.add_argument("--use_tpu", default=False, action='store_true', help="Whether to use TPU or GPU/CPU.") # parser.add_argument("--tpu_name", default=None, type=str, # help="The Cloud TPU to use for training. This should be either the name used when creating the " # "Cloud TPU, or a grpc://ip.address.of.tpu:8470 url.") @@ -101,7 +101,7 @@ parser.add_argument("--max_answer_length", default=30, type=int, # "Total number of TPU cores to use.") ### END - TO DELETE EVENTUALLY --> NO SENSE IN PYTORCH ### -parser.add_argument("--verbose_logging", default=False, type=bool, +parser.add_argument("--verbose_logging", default=False, action='store_true', help="If true, all of the warnings related to data processing will be printed. " "A number of warnings are expected for a normal SQuAD evaluation.") parser.add_argument("--no_cuda", diff --git a/tokenization_test_pytorch.py b/tokenization_test_pytorch.py index de6d06dfe2..a851fcbcb0 100644 --- a/tokenization_test_pytorch.py +++ b/tokenization_test_pytorch.py @@ -17,7 +17,6 @@ from __future__ import division from __future__ import print_function import os -import tempfile import unittest import tokenization_pytorch as tokenization @@ -122,4 +121,4 @@ class TokenizationTest(unittest.TestCase): if __name__ == '__main__': - unittest.main() \ No newline at end of file + unittest.main()