From 401377e6796a5939bbd4cd6c3b8d8d00ca33495d Mon Sep 17 00:00:00 2001 From: Bram Vanroy Date: Thu, 26 Aug 2021 10:32:57 +0200 Subject: [PATCH] Add error message concerning revision (#13266) * add error message concerning revision * Update src/transformers/configuration_utils.py Co-authored-by: Lysandre Debut * re-add double line endings * is not None instead of implicit bool casting Co-authored-by: Lysandre Debut --- src/transformers/configuration_utils.py | 4 ++++ src/transformers/modeling_utils.py | 6 +++++- src/transformers/tokenization_utils_base.py | 4 ++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/transformers/configuration_utils.py b/src/transformers/configuration_utils.py index 9649a176e8..0015355c90 100755 --- a/src/transformers/configuration_utils.py +++ b/src/transformers/configuration_utils.py @@ -541,6 +541,10 @@ class PretrainedConfig(PushToHubMixin): f"- '{pretrained_model_name_or_path}' is a correct model identifier listed on 'https://huggingface.co/models'\n\n" f"- or '{pretrained_model_name_or_path}' is the correct path to a directory containing a {CONFIG_NAME} file\n\n" ) + + if revision is not None: + msg += f"- or '{revision}' is a valid git identifier (branch name, a tag name, or a commit id) that exists for this model name as listed on its model page on 'https://huggingface.co/models'\n\n" + raise EnvironmentError(msg) except json.JSONDecodeError: diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py index 208d526b2c..b52180125f 100644 --- a/src/transformers/modeling_utils.py +++ b/src/transformers/modeling_utils.py @@ -1265,8 +1265,12 @@ class PreTrainedModel(nn.Module, ModuleUtilsMixin, GenerationMixin, PushToHubMix msg = ( f"Can't load weights for '{pretrained_model_name_or_path}'. Make sure that:\n\n" f"- '{pretrained_model_name_or_path}' is a correct model identifier listed on 'https://huggingface.co/models'\n\n" - f"- or '{pretrained_model_name_or_path}' is the correct path to a directory containing a file named one of {WEIGHTS_NAME}, {TF2_WEIGHTS_NAME}, {TF_WEIGHTS_NAME}.\n\n" + f"- or '{pretrained_model_name_or_path}' is the correct path to a directory containing a file named one of {WEIGHTS_NAME}, {TF2_WEIGHTS_NAME}, {TF_WEIGHTS_NAME}\n\n" ) + + if revision is not None: + msg += f"- or '{revision}' is a valid git identifier (branch name, a tag name, or a commit id) that exists for this model name as listed on its model page on 'https://huggingface.co/models'\n\n" + raise EnvironmentError(msg) if resolved_archive_file == archive_file: diff --git a/src/transformers/tokenization_utils_base.py b/src/transformers/tokenization_utils_base.py index 55670bcc61..fda8892b82 100644 --- a/src/transformers/tokenization_utils_base.py +++ b/src/transformers/tokenization_utils_base.py @@ -1723,6 +1723,10 @@ class PreTrainedTokenizerBase(SpecialTokensMixin, PushToHubMixin): f"- '{pretrained_model_name_or_path}' is a correct model identifier listed on 'https://huggingface.co/models'\n\n" f"- or '{pretrained_model_name_or_path}' is the correct path to a directory containing relevant tokenizer files\n\n" ) + + if revision is not None: + msg += f"- or '{revision}' is a valid git identifier (branch name, a tag name, or a commit id) that exists for this model name as listed on its model page on 'https://huggingface.co/models'\n\n" + raise EnvironmentError(msg) for file_id, file_path in vocab_files.items():