From 3233b58ad4aceb9d048b3c48cad44ef526470b53 Mon Sep 17 00:00:00 2001
From: Aymeric Augustin <aymeric.augustin@fractalideas.com>
Date: Fri, 27 Dec 2019 08:50:25 +0100
Subject: [PATCH] Quote square brackets in shell commands.

This ensures compatibility with zsh.

Fix #2316.
---
 CONTRIBUTING.md                      | 2 +-
 README.md                            | 4 ++--
 docs/README.md                       | 2 +-
 src/transformers/commands/serving.py | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 7ff83ce0cc..4887dc5764 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -121,7 +121,7 @@ Follow these steps to start contributing:
 4. Set up a development environment by running the following command in a virtual environment:
 
    ```bash
-   $ pip install -e .[dev]
+   $ pip install -e ".[dev]"
    ```
 
    (If transformers was already installed in the virtual environment, remove
diff --git a/README.md b/README.md
index 7a96004c58..da419d79f4 100644
--- a/README.md
+++ b/README.md
@@ -120,14 +120,14 @@ Depending on which framework is installed (TensorFlow 2.0 and/or PyTorch), the i
 Here's the easiest way to run tests for the library:
 
 ```bash
-pip install -e .[testing]
+pip install -e ".[testing]"
 make test
 ```
 
 and for the examples:
 
 ```bash
-pip install -e .[testing]
+pip install -e ".[testing]"
 pip install -r examples/requirements.txt
 make test-examples
 ```
diff --git a/docs/README.md b/docs/README.md
index 1c989d8c90..d1a8b24103 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -4,7 +4,7 @@ To generate the documentation, you first have to build it. Several packages are
 you can install them with the following command, at the root of the code repository:
 
 ```bash
-pip install -e .[docs]
+pip install -e ".[docs]"
 ```
 
 ## Packages installed
diff --git a/src/transformers/commands/serving.py b/src/transformers/commands/serving.py
index c5000263f3..1a44546c85 100644
--- a/src/transformers/commands/serving.py
+++ b/src/transformers/commands/serving.py
@@ -109,7 +109,7 @@ class ServeCommand(BaseTransformersCLICommand):
         if not _serve_dependancies_installed:
             raise RuntimeError(
                 "Using serve command requires FastAPI and unicorn. "
-                "Please install transformers with [serving]: pip install transformers[serving]."
+                "Please install transformers with [serving]: pip install \"transformers[serving]\"."
                 "Or install FastAPI and unicorn separately."
             )
         else: