From 182afb7dc6f40aea5f5bb41710cb5207d187b022 Mon Sep 17 00:00:00 2001 From: Kaustubh Dhole Date: Mon, 6 Feb 2023 09:27:34 -0500 Subject: [PATCH] Fixed RAG script which was failing on dummy example (#21416) * do not use prefix="val" for test The dummy example fails when test_epoch_end is called. The prefix="test" should be dynamic in the log metrics too. * Create test.source * Create test.target --- .../rag-end2end-retriever/finetune_rag.py | 8 ++++---- .../test_run/dummy-train-data/test.source | 8 ++++++++ .../test_run/dummy-train-data/test.target | 8 ++++++++ 3 files changed, 20 insertions(+), 4 deletions(-) create mode 100644 examples/research_projects/rag-end2end-retriever/test_run/dummy-train-data/test.source create mode 100644 examples/research_projects/rag-end2end-retriever/test_run/dummy-train-data/test.target diff --git a/examples/research_projects/rag-end2end-retriever/finetune_rag.py b/examples/research_projects/rag-end2end-retriever/finetune_rag.py index 1229870e63..53e1e657f7 100644 --- a/examples/research_projects/rag-end2end-retriever/finetune_rag.py +++ b/examples/research_projects/rag-end2end-retriever/finetune_rag.py @@ -408,11 +408,11 @@ class GenerativeQAModule(BaseTransformer): self.save_metrics(metrics, prefix) # writes to self.metrics_save_path log_dict = { - "val_avg_em": metrics["val_avg_em"], + f"{prefix}_avg_em": metrics[f"{prefix}_avg_em"], "step_count": metrics["step_count"], - "val_avg_loss": metrics["val_avg_loss"], - "val_loss": loss, - "val_em": metrics_tensor, + f"{prefix}_avg_loss": metrics[f"{prefix}_avg_loss"], + f"{prefix}_loss": loss, + f"{prefix}_em": metrics_tensor, } self.log_dict(log_dict) diff --git a/examples/research_projects/rag-end2end-retriever/test_run/dummy-train-data/test.source b/examples/research_projects/rag-end2end-retriever/test_run/dummy-train-data/test.source new file mode 100644 index 0000000000..3d5cbc3803 --- /dev/null +++ b/examples/research_projects/rag-end2end-retriever/test_run/dummy-train-data/test.source @@ -0,0 +1,8 @@ +What does Moses' rod turn into ? +Who is Aron? +Where did Moses grow up ? +What happens at the command of the Moses ? +Who manages the Pokémon ? +Who owned the Pokémon trademark ? +What else include in Pokémon franchise ? +How many seasons in Pokémon animme series ? diff --git a/examples/research_projects/rag-end2end-retriever/test_run/dummy-train-data/test.target b/examples/research_projects/rag-end2end-retriever/test_run/dummy-train-data/test.target new file mode 100644 index 0000000000..a3a6e04372 --- /dev/null +++ b/examples/research_projects/rag-end2end-retriever/test_run/dummy-train-data/test.target @@ -0,0 +1,8 @@ +to a snake +Moses' assistant +Egyptian royal court +let his rod turn in to a snake +The Pokémon Company +Nintendo +world's top-selling toy brand, the top-selling trading card game +over 20 seasons