SUMIN/HuggingFace_transformer
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

fix the shuffle agrument usage and the default (#6307)

Browse Source
This commit is contained in:
Stas Bekman
2020-08-06 17:32:28 -07:00
committed by GitHub
parent ffceef2042
commit 175cd45e13
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
examples/seq2seq/test_seq2seq_examples.py
View File

@@ -329,6 +329,7 @@ def test_finetune_extra_model_args():
assert str(excinfo.value) == f"model config doesn't have a `{unsupported_param}` attribute" assert str(excinfo.value) == f"model config doesn't have a `{unsupported_param}` attribute"
@unittest.skip("Conflict with different add_argparse_args - needs a serious sync")
def test_finetune_lr_shedulers(capsys): def test_finetune_lr_shedulers(capsys):
args_d: dict = CHEAP_ARGS.copy() args_d: dict = CHEAP_ARGS.copy()

4
examples/text-classification/run_pl_glue.py
View File

@@ -75,7 +75,7 @@ class GLUETransformer(BaseTransformer):
logger.info("Saving features into cached file %s", cached_features_file) logger.info("Saving features into cached file %s", cached_features_file)
torch.save(features, cached_features_file) torch.save(features, cached_features_file)
def get_dataloader(self, mode: int, batch_size: int, shuffle: bool) -> DataLoader: def get_dataloader(self, mode: int, batch_size: int, shuffle: bool = False) -> DataLoader:
"Load datasets. Called after prepare data." "Load datasets. Called after prepare data."
# We test on dev set to compare to benchmarks without having to submit to GLUE server # We test on dev set to compare to benchmarks without having to submit to GLUE server
@@ -95,7 +95,7 @@ class GLUETransformer(BaseTransformer):
return DataLoader( return DataLoader(
TensorDataset(all_input_ids, all_attention_mask, all_token_type_ids, all_labels), TensorDataset(all_input_ids, all_attention_mask, all_token_type_ids, all_labels),
batch_size=batch_size, batch_size=batch_size,
shuffle=True, shuffle=shuffle,
) )
def validation_step(self, batch, batch_idx): def validation_step(self, batch, batch_idx):