From 0d309ce39ab2582ecb409d0f824d779b7e397c9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=9C=D0=B0=D0=BA=D1=81=D0=B8=D0=BC=20=D0=97=D0=B0=D1=8F?= =?UTF-8?q?=D0=BA=D0=B8=D0=BD?= Date: Thu, 7 Oct 2021 12:14:23 +0500 Subject: [PATCH] Raise exceptions instead of asserts (#13907) --- utils/download_glue_data.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/utils/download_glue_data.py b/utils/download_glue_data.py index ab345c4e72..ef482d47de 100644 --- a/utils/download_glue_data.py +++ b/utils/download_glue_data.py @@ -68,8 +68,10 @@ def format_mrpc(data_dir, path_to_data): mrpc_test_file = os.path.join(mrpc_dir, "msr_paraphrase_test.txt") urllib.request.urlretrieve(MRPC_TRAIN, mrpc_train_file) urllib.request.urlretrieve(MRPC_TEST, mrpc_test_file) - assert os.path.isfile(mrpc_train_file), "Train data not found at %s" % mrpc_train_file - assert os.path.isfile(mrpc_test_file), "Test data not found at %s" % mrpc_test_file + if not os.path.isfile(mrpc_train_file): + raise ValueError(f"Train data not found at {mrpc_train_file}") + if not os.path.isfile(mrpc_test_file): + raise ValueError(f"Test data not found at {mrpc_test_file}") urllib.request.urlretrieve(TASK2PATH["MRPC"], os.path.join(mrpc_dir, "dev_ids.tsv")) dev_ids = [] @@ -118,7 +120,8 @@ def get_tasks(task_names): else: tasks = [] for task_name in task_names: - assert task_name in TASKS, "Task %s not found!" % task_name + if task_name not in TASKS: + raise ValueError(f"Task {task_name} not found!") tasks.append(task_name) return tasks